Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update objectcontrol for time lib independent ISO library #268

Merged
merged 5 commits into from
Jul 3, 2020

Conversation

LukasWikander
Copy link
Collaborator

As I've updated the ISO library to take time as input for e.g. MONR decoding to avoid using the system clock in those functions, objectcontrol needed updating.

@LukasWikander LukasWikander requested a review from sepast June 25, 2020 14:54
@LukasWikander LukasWikander changed the title Updated util reference and modified function calls Update objectcontrol for time lib independent ISO library Jun 25, 2020
@LukasWikander
Copy link
Collaborator Author

@sepast , this is a compatibility pull request for the one you're reviewing in the util repo, so please review this as well.

core/src/objectcontrol.c Outdated Show resolved Hide resolved
Copy link
Contributor

@alfaro01 alfaro01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't reviewed the other one but based on what's in this one I can't see what could go wrong with these changes. I had only a tiny comment but nice and concise PR otherwise 👍

@LukasWikander LukasWikander merged commit afadb0c into dev Jul 3, 2020
@LukasWikander LukasWikander deleted the feature_updateIsoLibraryFunctionWithTimeInput branch July 3, 2020 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants