Clarify pull request workflow #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
June release, version 0.5.0
|
|
||
| 11. Merge the pull request into the **staging** or **feature** branch, and then delete it on github. | ||
| 12. Run applicable test again on the merged code. | ||
| * Is a triple nested ternary really necessary or is a two liner easier to comprehend? |
konglobemeralt
approved these changes
Jun 18, 2020
There was a problem hiding this comment.
A lot of good additions and improvements to the old text. Lets try to follow this as much as we can! Added some suggestions to point out that the Util repo should perhaps also be part of the last "pull sequence" to ensure everything is working with the latest iteration of util.
Co-authored-by: Jesper Blidkvist <[email protected]>
Co-authored-by: Jesper Blidkvist <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also cleaned up the section above.