Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature "ClearTrajectories();" command #228

Merged
merged 11 commits into from
Mar 13, 2020
Merged

Feature "ClearTrajectories();" command #228

merged 11 commits into from
Mar 13, 2020

Conversation

viktorjo
Copy link
Contributor

@viktorjo viktorjo commented Mar 4, 2020

Added new clear trajectory command. Can now be accessed through GUC via calling ClearTrajectories();

@viktorjo viktorjo requested a review from a team March 4, 2020 10:24
LukasWikander
LukasWikander approved these changes Mar 4, 2020
View reviewed changes
Copy link
Collaborator

@LukasWikander LukasWikander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some guards and stuff missing which should be added as well as some other minor stuff. See comments.

server/src/systemcontrol.c Outdated Show resolved Hide resolved
server/src/systemcontrol.c Outdated Show resolved Hide resolved
server/src/systemcontrol.c Outdated Show resolved Hide resolved
server/src/systemcontrol.c Outdated Show resolved Hide resolved
server/src/util.c Outdated Show resolved Hide resolved
server/src/util.c Outdated Show resolved Hide resolved
@viktorjo viktorjo requested a review from LukasWikander March 6, 2020 09:36
@viktorjo viktorjo merged commit d634391 into dev Mar 13, 2020
@viktorjo viktorjo deleted the feature_clearTrajctoriesCommand branch March 13, 2020 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukasWikander LukasWikander LukasWikander approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@viktorjo @LukasWikander @konglobemeralt