Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin settings broken. #11

Closed
exploitJ opened this issue Oct 13, 2022 · 6 comments
Closed

Plugin settings broken. #11

exploitJ opened this issue Oct 13, 2022 · 6 comments
Assignees

Comments

@exploitJ
Copy link

exploitJ commented Oct 13, 2022

My env

  • Obsidian version: 1.0.0
  • OS: macOS 12.6

Issue

  • selecting plugin does not work.
  • selecting command does not work.

Edit:
doubleshift's default setting Open Command Pallet DOES work.
However, I used to add other plugin's command; I don't use core plugin Command Pallet.

Add Button next to Shortcuts section from the doubleshift settings panel doesn't work.
When clicked, error log shows on the dev console.

Detailed Console error log

plugin:obsidian-doubleshift:64 Uncaught TypeError: Cannot read properties of null (reading 'name')
    at new commandSuggestion (plugin:obsidian-doubleshift:64:66)
    at new ShortcutCreator (plugin:obsidian-doubleshift:93:5)
    at eval (plugin:obsidian-doubleshift:149:9)
    at HTMLButtonElement.<anonymous> (app.js:1:1114448)
commandSuggestion @ plugin:obsidian-doubleshift:64
ShortcutCreator @ plugin:obsidian-doubleshift:93
eval @ plugin:obsidian-doubleshift:149
(anonymous) @ app.js:1
@ghost
Copy link

ghost commented Oct 14, 2022

Sadly this seems to be the case with many plugins. I can't complain too much. After all, there are a lot of new features and fixes, albeit many of the new features have introduced other, new bugs, but it's not the end of the world. As for me, I'm just going to uninstall and install 0.15.9 again, then wait till 1.0.0 is more "stable". But yeah, doubleshift is by far one of my favorite plugins, so I hear you. Of course, it's not our homie Qwyntex' fault; he rocks. But thx for adding the issue so it can be resolved. And knowing Qwyntex, it will be resolved real soon. :D

@Qwyntex
Copy link
Owner

Qwyntex commented Oct 15, 2022

I have just tried it and it seems to be working alright. If the issue consists please provide more information on how to recreate it. Otherwise just close the issue

@Qwyntex Qwyntex self-assigned this Oct 15, 2022
@exploitJ
Copy link
Author

Sorry, I should have elaborated more on reproducing bug.

@Qwyntex
Copy link
Owner

Qwyntex commented Oct 18, 2022

The issue should now be fixed. Please update to the newest plugin version. Should any new issues arise due to me updating to a newer API version please report them.

@Qwyntex Qwyntex closed this as completed Oct 18, 2022
@ghost
Copy link

ghost commented Oct 18, 2022

As always, you are my HERO, Qwyntex! Thanks for everything! 👍🏻

@sdrakulich
Copy link

For what it's worth: I had to fully uninstall and reinstall doubleshift plugin in order to fix absence of plugin-specific commands in doubleshift settings.

Note that I had updated the plugin today, and verified the above was not functioning, prior to my reinstallation of doubleshift.

Thanks for the plugin btw 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants