Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bulk tag adding feature #227

Open
atruskie opened this issue Aug 5, 2015 · 13 comments
Open

Bulk tag adding feature #227

atruskie opened this issue Aug 5, 2015 · 13 comments

Comments

@atruskie
Copy link
Member

atruskie commented Aug 5, 2015

Hack for now, hidden by default, bulk enter tags.

Text input, delimited by csv. Simulate adding one at a time. Silent fail if no match. Clear text box after lose focus.

For @JessCappadonna

@atruskie
Copy link
Member Author

atruskie commented Aug 7, 2015

So it turns out the library already supports copy-pasting tags in... it is just really bad and broken. Hacking it now...!

atruskie added a commit that referenced this issue Aug 7, 2015
Fixes #227 - bulk adding tags now supported. Fixes #226 - broken tags due to missing lodash dependency
@JessieLOliver
Copy link

Example (no spaces between tags and no quotes):
screech,duet,no echo

@JessieLOliver
Copy link

When attempting to paste multiple tags in the tag bar on any visualisation page (e.g. http://www.ecosounds.org/listen/262860?start=7020&end=7050) with "flower-shaped,Eastern Bristlebird" it would on occasion work, creating two tags. Most of the time, however, only one tag would paste such as "flower-shape". Sometimes refreshing would allow me to paste two tags again, but other times refreshing the page (F5) did nothing. @cofiem also experienced these issues.

@atruskie
Copy link
Member Author

I just created 3 annotations and used the copy-pasta method, at the link you provided, that all worked. Can you narrow down the bug case at all?

@JessieLOliver
Copy link

Sorry, I don't know how to.... perhaps Mark can say more specifically what was happening, but I don't know how to add him to the conversation

@cofiem
Copy link
Contributor

cofiem commented Sep 29, 2015

baw-client-0.17.3.js:40 AnnotationEditor:modelUpdated: 137398 false
baw-client-0.17.3.js:40 AnnotationEditor:modelUpdatesDrawabox: 137398
baw-client-0.17.3.js:38 Assertion failed: The taggings array and tags array are out of sync, this is bad(anonymous function) @ baw-client-0.17.3.js:38
baw-client-0.17.3.js:38 Tag addition success flower-shaped
baw-client-0.17.3.js:40 AnnotationEditor:modelUpdated: 137398 false
baw-client-0.17.3.js:40 AnnotationEditor:modelUpdatesDrawabox: 137398

@cofiem
Copy link
Contributor

cofiem commented Sep 29, 2015

AnnotationEditor:modelUpdatesDrawabox: -12
baw-client-0.17.3.js:38 Assertion failed: The taggings array and tags array are out of sync, this is bad(anonymous function) @ baw-client-0.17.3.js:38(anonymous function) @ baw-client-0.17.3.js:28i @ baw-client-0.17.3.js:14(anonymous function) @ baw-client-0.17.3.js:14a.$get.n.$eval @ baw-client-0.17.3.js:14a.$get.n.$digest @ baw-client-0.17.3.js:14a.$get.n.$apply @ baw-client-0.17.3.js:14f @ baw-client-0.17.3.js:14r @ baw-client-0.17.3.js:14v.onload @ baw-client-0.17.3.js:14
baw-client-0.17.3.js:38 Tag addition success Eastern Bristlebird

@cofiem
Copy link
Contributor

cofiem commented Sep 29, 2015

nnotationEditor:modelUpdatesDrawabox: -1
baw-client-0.17.3.js:38 decipher.tags.addfailed [Object, Object]0: ObjectcurrentScope: nulldefaultPrevented: falsename: "decipher.tags.addfailed"preventDefault: ()stopPropagation: ()targetScope: n__proto__: Object1: Objectcallee: (...)get callee: ThrowTypeError()set callee: ThrowTypeError()caller: (...)get caller: ThrowTypeError()set caller: ThrowTypeError()length: 2Symbol(Symbol.iterator): values()__proto__: Object
baw-client-0.17.3.js:38 decipher.tags.addfailed [Object, Object]0: Object1: Objectcallee: (...)get callee: ThrowTypeError()set callee: ThrowTypeError()caller: (...)get caller: ThrowTypeError()set caller: ThrowTypeError()length: 2Symbol(Symbol.iterator): values()__proto__: Object
baw-client-0.17.3.js:38 Tag addition success flower-shaped

@atruskie
Copy link
Member Author

Ahh that last log is useful - what did you different?

@cofiem
Copy link
Contributor

cofiem commented Sep 29, 2015

I think I've figured it out - incoming repro steps

@cofiem
Copy link
Contributor

cofiem commented Sep 29, 2015

  1. create a box
  2. paste "flower-shaped,Eastern Bristlebird,no echo" into the tag field
  3. move the box
  4. resize the box
  5. delete all 3 tags from right to left
  6. paste "flower-shaped,Eastern Bristlebird,no echo" into the tag field
  7. "flower-shaped,no echo" will be added, "Eastern Bristlebird" will not be added

@atruskie
Copy link
Member Author

👍 💯 😲 😮

Brilliant, confirmed.

@atruskie atruskie reopened this Sep 29, 2015
@cofiem
Copy link
Contributor

cofiem commented Sep 29, 2015

Does not seem to affect tags the same way, but I can't find any consistencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants