Skip to content

Commit

Permalink
fix(visualize): Unrestricted pan-right bug
Browse files Browse the repository at this point in the history
Turns out it was just a JavaScript type coercion bug - pretty much fixed
it accidently when I mindlessly prefixed date variables with `+` to cast
them to number form. Fixes #271
  • Loading branch information
atruskie committed Jun 21, 2016
1 parent d4878ea commit 42dac1a
Showing 1 changed file with 7 additions and 5 deletions.
12 changes: 7 additions & 5 deletions src/app/d3Bindings/eventDistribution/distributionDetail.js
Original file line number Diff line number Diff line change
Expand Up @@ -1026,16 +1026,18 @@ angular
xDomain = xScale.domain(),
x1 = +xDomain[1],
x0 = +xDomain[0],
halfDomainDuration = (x1 - x0) / 2.0;
halfDomainDuration = (x1 - x0) / 2.0,
dataMinimum = +self.minimum,
dataMaximum = +self.maximum;

// extent allowable pan range by half of the current on-screen visible domain
var panExtent0 = self.minimum - halfDomainDuration,
panExtent1 = self.maximum + halfDomainDuration;
var panExtent0 = dataMinimum - halfDomainDuration,
panExtent1 = dataMaximum + halfDomainDuration;

if (x0 < panExtent0) {
tx = xScale(self.minimum - (panExtent0 - x0));
tx = xScale(dataMinimum - (panExtent0 - x0));
} else if (x1 > panExtent1) {
tx = xScale((panExtent1 - self.maximum) + x1 - (panExtent1 - panExtent0));
tx = xScale((panExtent1 - dataMaximum) + x1 - (panExtent1 - panExtent0));
} else {
tx = zoom.translate()[0];
}
Expand Down

0 comments on commit 42dac1a

Please sign in to comment.