From ddb70fe8ead445a9af165c82f638587645ceb375 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Marta=20Marczykowska-G=C3=B3recka?= Date: Tue, 30 Apr 2019 16:12:27 +0200 Subject: [PATCH] Added additional check for cloning a VM An attempt to clone a VM to a name that is already in use will fail more gracefully and with an explicit warning message. --- qubesmanager/qube_manager.py | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/qubesmanager/qube_manager.py b/qubesmanager/qube_manager.py index 000133d0..9ca7802d 100644 --- a/qubesmanager/qube_manager.py +++ b/qubesmanager/qube_manager.py @@ -504,7 +504,7 @@ def __init__(self, qt_app, qubes_app, dispatcher, parent=None): # Check Updates Timer timer = QtCore.QTimer(self) timer.timeout.connect(self.check_updates) - timer.start(1000 * 30) # 30s + timer.start(1000 * 30) # 30s self.check_updates() def keyPressEvent(self, event): # pylint: disable=invalid-name @@ -852,6 +852,15 @@ def action_clonevm_triggered(self): if not ok or clone_name == "": return + name_in_use = clone_name in self.qubes_app.domains + + if name_in_use: + QtGui.QMessageBox.warning( + None, self.tr("Name already in use!"), + self.tr("There already exists a qube called '{}'. " + "Cloning aborted.").format(clone_name)) + return + self.progress = QtGui.QProgressDialog( self.tr( "Cloning Qube..."), "", 0, 0)