Avoid passing stderr_fd to handle_data_client

It is always -1, and an assertion would fail if it was not.

Author: DemiMarie

agent/qrexec-agent-data.c

@@ -322,7 +322,7 @@ pid_t handle_new_process(int type, int connect_domain, int connect_port,
 /* Returns exit code of remote process */
 int handle_data_client(
     int type, int connect_domain, int connect_port,
-    int stdin_fd, int stdout_fd, int stderr_fd, int buffer_size, pid_t pid,
+    int stdin_fd, int stdout_fd, int buffer_size, pid_t pid,
     const char *extra_data)
 {
     int exit_code;
@@ -362,7 +362,7 @@ int handle_data_client(
 
     req.stdin_fd = stdin_fd;
     req.stdout_fd = stdout_fd;
-    req.stderr_fd = stderr_fd;
+    req.stderr_fd = -1;
     req.local_pid = pid;
 
     req.is_service = false;

agent/qrexec-agent.h

@@ -45,7 +45,7 @@ pid_t handle_new_process(int type,
         struct qrexec_parsed_command *cmd);
 int handle_data_client(int type,
         int connect_domain, int connect_port,
-        int stdin_fd, int stdout_fd, int stderr_fd,
+        int stdin_fd, int stdout_fd,
         int buffer_size, pid_t pid, const char *extra_data);
 
 

agent/qrexec-client-vm.c

@@ -324,11 +324,11 @@ int main(int argc, char **argv)
 
         ret = handle_data_client(MSG_SERVICE_CONNECT,
                 exec_params.connect_domain, exec_params.connect_port,
-                inpipe[1], outpipe[0], -1, buffer_size, child_pid, prefix_data);
+                inpipe[1], outpipe[0], buffer_size, child_pid, prefix_data);
     } else {
         ret = handle_data_client(MSG_SERVICE_CONNECT,
                 exec_params.connect_domain, exec_params.connect_port,
-                stdout_fd, 0, -1, buffer_size, 0, prefix_data);
+                stdout_fd, 0, buffer_size, 0, prefix_data);
     }
 
     close(trigger_fd);