Skip to content

Commit 4dbf597

Browse files
committed
q-dev: do not include port id in device identity
device identity should contain only device provided data
1 parent 97084d6 commit 4dbf597

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

qubes/ext/block.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -235,7 +235,7 @@ def device_id(self) -> str:
235235
p_info = p.backend_domain.devices[p.devclass][p.port_id]
236236
parent_identity = p_info.device_id
237237
if p.devclass == 'usb':
238-
parent_identity = f'{p.port_id}:{parent_identity}'
238+
parent_identity = f'{parent_identity}'
239239
if self._interface_num:
240240
# device interface number (not partition)
241241
self_id = self._interface_num

qubes/tests/devices_block.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -260,7 +260,7 @@ def test_000_device_get(self):
260260
self.assertEqual(device_info.parent_device, parent)
261261
self.assertEqual(device_info.attachment, front)
262262
self.assertEqual(device_info.device_id,
263-
'1-1.1:0000:0000::?******:1.0')
263+
'0000:0000::?******:1.0')
264264
self.assertEqual(
265265
device_info.data.get('test_frontend_domain', None), None)
266266
self.assertEqual(device_info.device_node, '/dev/sda')

0 commit comments

Comments
 (0)