Skip to content

Commit 1302bf9

Browse files
committed
q-dev: fix test
1 parent 6dd8f56 commit 1302bf9

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

qubes/ext/block.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -594,7 +594,7 @@ async def on_domain_shutdown(self, vm, event, **_kwargs):
594594
if front_vm == vm:
595595
dev = BlockDevice(vm, dev_id)
596596
asyncio.ensure_future(front_vm.fire_event_async(
597-
'device-detach:block', port=dev))
597+
'device-detach:block', port=dev.port))
598598
else:
599599
new_cache[domain.name][dev_id] = front_vm
600600
self.devices_cache = new_cache.copy()
@@ -604,7 +604,7 @@ async def _detach_and_notify(self, vm, device, options):
604604
self.on_device_pre_detached_block(
605605
vm, 'device-pre-detach:block', device.port)
606606
await vm.fire_event_async(
607-
'device-detach:block', port=device, options=options)
607+
'device-detach:block', port=device.port, options=options)
608608

609609
@qubes.ext.handler('qubes-close', system=True)
610610
def on_qubes_close(self, app, event):

qubes/ext/utils.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ def device_list_change(
4545
for dev_id, front_vm in detached.items():
4646
dev = device_class(vm, dev_id)
4747
asyncio.ensure_future(front_vm.fire_event_async(
48-
f'device-detach:{devclass}', port=dev))
48+
f'device-detach:{devclass}', port=dev.port))
4949
for dev_id in removed:
5050
device = device_class(vm, dev_id)
5151
vm.fire_event(f'device-removed:{devclass}', device=device)

qubes/tests/devices_block.py

+3-3
Original file line numberDiff line numberDiff line change
@@ -833,9 +833,9 @@ def test_063_on_qdb_change_changed(self):
833833

834834
self.assertEqual(self.ext.devices_cache, {'sys-usb': {'sda': front_2}})
835835
fire_event_async.assert_called_with(
836-
'device-detach:block', port=exp_dev)
836+
'device-detach:block', port=exp_dev.port)
837837
fire_event_async_2.assert_called_once_with(
838-
'device-attach:block', port=exp_dev, options={})
838+
'device-attach:block', device=exp_dev, options={})
839839

840840
def test_064_on_qdb_change_removed_attached(self):
841841
# attached to front-vm
@@ -889,7 +889,7 @@ def test_064_on_qdb_change_removed_attached(self):
889889
self.ext.on_qdb_change(back_vm, None, None)
890890
self.assertEqual(self.ext.devices_cache, {'sys-usb': {}})
891891
fire_event_async.assert_called_with(
892-
'device-detach:block', port=exp_dev)
892+
'device-detach:block', port=exp_dev.port)
893893
self.assertEqual(
894894
back_vm.fired_events[
895895
('device-removed:block', frozenset({('device', exp_dev)}))],

0 commit comments

Comments
 (0)