Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shift-' does not work #33

Open
zwang20 opened this issue Nov 10, 2021 · 2 comments
Open

Shift-' does not work #33

zwang20 opened this issue Nov 10, 2021 · 2 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@zwang20
Copy link
Member

zwang20 commented Nov 10, 2021

Describe the bug
Pressing shift and ' does not add the " character

To Reproduce
Steps to reproduce the behavior:

  1. open program
  2. press shift and '
  3. See error

Expected behavior
A '"' character should be printed

Desktop

  • OS: should be os independent
@zwang20 zwang20 added the bug Something isn't working label Nov 10, 2021
@Edward-Ji
Copy link
Contributor

Currently, we are using a manual map. I wonder if there is a scalable way to convert them. In the future, we may also need characters like {, }, <, > etc.

@Edward-Ji
Copy link
Contributor

Also, there are mixed indentations (tabs and spaces) in modkeys.py. If someone were to add more modified keys, please unify the indentation as well.

@Edward-Ji Edward-Ji mentioned this issue Nov 15, 2021
Open
@zwang20 zwang20 added the good first issue Good for newcomers label Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Edward-Ji @zwang20