Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AlgorithmManager removal of delisted securities #4822

Open
4 tasks done
Martin-Molinero opened this issue Oct 5, 2020 · 1 comment
Open
4 tasks done

AlgorithmManager removal of delisted securities #4822

Martin-Molinero opened this issue Oct 5, 2020 · 1 comment

Comments

@Martin-Molinero
Copy link
Member

Martin-Molinero commented Oct 5, 2020

Expected Behavior

  • AlgorithmManager does not need to temper with universes members nor drive them

Actual Behavior

  • AlgorithmManager.HandleDelistedSymbols is manually going through all the universes and removing the delisted security, this is not following the normal procedure of removing a security from a universe which triggers universe selection and cleans up subscriptions/SubscriptionDataConfig at the data feed layer. Found when testing OptionChain and OptionContract improvements #4804

Potential Solution

  • Refactor removal of delisted securities so it's handled internally by the data feed and the universes

Reproducing the Problem

N/A

System Information

N/A

Checklist

  • I have completely filled out this template
  • I have confirmed that this issue exists on the current master branch
  • I have confirmed that this is not a duplicate issue by searching issues
  • I have provided detailed steps to reproduce the issue
@jaredbroad
Copy link
Member

  • Moved to BacktestingBrokerages
  • Goal to move to universes but would need to be processed on the next loop of the universe to give time to process the orders

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants