Contradictory terminology about native types #47
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
future.utils.native_str
is the default native string type.One would therefore conclude that
future.utils.bytes_to_native_str
was the correct way to turnnewbytes
into anative_str
, at least on Python 2. This does not work, as it is in fact a no-op on Python 2.Personally this could be solved with a hint in the docstring (and a pointer to use
native
), but it could also be seen as a naming or coding bug.Thanks for the lovely work. :)