-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Raise a MisconfigurationException
when trainer functions are called with ckpt_path="best"
but checkpoint_callback
isn't configured
#9841
Conversation
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
Codecov Report
@@ Coverage Diff @@
## master #9841 +/- ##
=======================================
- Coverage 93% 89% -4%
=======================================
Files 178 178
Lines 15647 15649 +2
=======================================
- Hits 14502 13895 -607
- Misses 1145 1754 +609 |
Co-authored-by: ananthsub <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ! Nice catch :)
Co-authored-by: thomas chaton <[email protected]>
checkpoint_callback
if ckpt_path='best'
MisconfigurationException
when trainer functions are called with ckpt_path="best"
but checkpoint_callback
isn't configured
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
… with `ckpt_path="best"` but `checkpoint_callback` isn't configured (Lightning-AI#9841) * add check * chlog * Apply suggestions from code review Co-authored-by: ananthsub <[email protected]> * Apply suggestions from code review Co-authored-by: thomas chaton <[email protected]> Co-authored-by: ananthsub <[email protected]> Co-authored-by: thomas chaton <[email protected]>
What does this PR do?
Right now if checkpoint callback is not configured and you do
trainer.test(ckpt_path='best')
then it raises:this is a bit confusing maybe, so just added a check to look for checkpoint callback first
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃