Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise an exception if using amp_level with native amp_backend #9755

Merged
merged 6 commits into from
Oct 1, 2021

Conversation

rohitgr7
Copy link
Contributor

What does this PR do?

Fixes #9739

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@rohitgr7 rohitgr7 changed the title add exception Raise an exception if using amp_level with native amp_backend Sep 29, 2021
@rohitgr7 rohitgr7 marked this pull request as ready for review September 29, 2021 15:20
@rohitgr7 rohitgr7 added this to the v1.5 milestone Sep 29, 2021
@codecov
Copy link

codecov bot commented Sep 29, 2021

Codecov Report

Merging #9755 (2e9fa59) into master (0d3325e) will increase coverage by 0%.
The diff coverage is 100%.

❗ Current head 2e9fa59 differs from pull request most recent head 382c196. Consider uploading reports for the commit 382c196 to get more accurate results

@@          Coverage Diff           @@
##           master   #9755   +/-   ##
======================================
  Coverage      93%     93%           
======================================
  Files         177     177           
  Lines       15460   15464    +4     
======================================
+ Hits        14317   14321    +4     
  Misses       1143    1143           

Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT !

@mergify mergify bot removed the has conflicts label Sep 30, 2021
@awaelchli awaelchli added feature Is an improvement or enhancement and removed refactor labels Sep 30, 2021
@mergify mergify bot added the ready PRs ready to be merged label Sep 30, 2021
@rohitgr7 rohitgr7 enabled auto-merge (squash) October 1, 2021 08:41
@rohitgr7 rohitgr7 merged commit 617e798 into master Oct 1, 2021
@rohitgr7 rohitgr7 deleted the bugfix/amp_lvl_native branch October 1, 2021 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Is an improvement or enhancement ready PRs ready to be merged
Projects
None yet
6 participants