-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for missing return obj from to function on custom batch objects #8433
Conversation
Codecov Report
@@ Coverage Diff @@
## master #8433 +/- ##
======================================
- Coverage 93% 92% -0%
======================================
Files 216 217 +1
Lines 14109 14113 +4
======================================
- Hits 13083 13018 -65
- Misses 1026 1095 +69 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a fan of us doing this but I guess it doesn't hurt. A tool like mypy would have reported the bug
Co-authored-by: Adrian Wälchli <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 😃
What does this PR do?
This PR adds support for moving custom data object on device where the object doesn't return self from the to function.
Example: https://github.com/intel-isl/Open3D-ML/blob/master/ml3d/torch/dataloaders/concat_batcher.py#L484
Does your PR introduce any breaking changes ? If yes, please list them.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃