Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for missing return obj from to function on custom batch objects #8433

Merged
merged 7 commits into from
Jul 19, 2021

Conversation

tchaton
Copy link
Contributor

@tchaton tchaton commented Jul 15, 2021

What does this PR do?

This PR adds support for moving custom data object on device where the object doesn't return self from the to function.

Example: https://github.com/intel-isl/Open3D-ML/blob/master/ml3d/torch/dataloaders/concat_batcher.py#L484

Does your PR introduce any breaking changes ? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)
  • Did you list all the breaking changes introduced by this pull request?

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@tchaton tchaton added the bug Something isn't working label Jul 15, 2021
@tchaton tchaton added this to the v1.4 milestone Jul 15, 2021
@tchaton tchaton self-assigned this Jul 15, 2021
@codecov
Copy link

codecov bot commented Jul 15, 2021

Codecov Report

Merging #8433 (a7aa566) into master (ae1fd6a) will decrease coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #8433   +/-   ##
======================================
- Coverage      93%     92%   -0%     
======================================
  Files         216     217    +1     
  Lines       14109   14113    +4     
======================================
- Hits        13083   13018   -65     
- Misses       1026    1095   +69     

Copy link
Contributor

@carmocca carmocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a fan of us doing this but I guess it doesn't hurt. A tool like mypy would have reported the bug

pytorch_lightning/utilities/apply_func.py Show resolved Hide resolved
@mergify mergify bot removed the has conflicts label Jul 16, 2021
Copy link
Member

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😃

@tchaton tchaton enabled auto-merge (squash) July 16, 2021 17:06
@carmocca carmocca added the ready PRs ready to be merged label Jul 18, 2021
@tchaton tchaton merged commit 257fabd into master Jul 19, 2021
@tchaton tchaton deleted the bug_fix_move_data branch July 19, 2021 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants