-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for functions to be parsed by the Lightning CLI in addition to Types #8400
Conversation
Codecov Report
@@ Coverage Diff @@
## master #8400 +/- ##
======================================
- Coverage 88% 88% -0%
======================================
Files 218 218
Lines 14401 14390 -11
======================================
- Hits 12680 12669 -11
Misses 1721 1721 |
…orchLightning/pytorch-lightning into feature/cli_function_support
There are some mypy complains to address |
@carmocca Yeah, mypy wasn't picking up |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
@mauvilsa thanks for the updates 😃 I've updated the PR with the required changes, mind taking another look? |
…orchLightning/pytorch-lightning into feature/cli_function_support
What does this PR do?
Adds support for functions (e.g. classmethods) to be provided to the CLI in addition to types.
Needed for FlashCLI where we have data modules created from clasmethods
Does your PR introduce any breaking changes ? If yes, please list them.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃