-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move mixin to core #8396
Move mixin to core #8396
Conversation
Codecov Report
@@ Coverage Diff @@
## master #8396 +/- ##
=======================================
- Coverage 93% 88% -5%
=======================================
Files 216 217 +1
Lines 14115 14116 +1
=======================================
- Hits 13087 12423 -664
- Misses 1028 1693 +665 |
just curious, what is the motivation? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
doesn't the device_dtype_mixin require a rerouting of the imports for BC?
I don't think it would be required for internal use. |
Not for internal use, but it was part of the public API in utilities (I use it quite often in my own code) so I think we should reroute this together with a Deprecation Warning |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
What does this PR do?
Fixes #<issue_number>
Does your PR introduce any breaking changes ? If yes, please list them.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃