Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove magic monitor support for ModelCheckpoint #8293

Merged
merged 8 commits into from
Jul 7, 2021

Conversation

carmocca
Copy link
Contributor

@carmocca carmocca commented Jul 5, 2021

What does this PR do?

Remove deprecated support for relying on the magic monitor val_loss. save_top_k does not need to be Optional anymore.

Before submitting

  • [n/a] Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • [n/a] Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@codecov
Copy link

codecov bot commented Jul 5, 2021

Codecov Report

Merging #8293 (6afb295) into master (fc12fe7) will increase coverage by 4%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #8293    +/-   ##
=======================================
+ Coverage      88%     92%    +4%     
=======================================
  Files         213     213            
  Lines       13808   13797    -11     
=======================================
+ Hits        12151   12730   +579     
+ Misses       1657    1067   -590     

CHANGELOG.md Outdated Show resolved Hide resolved
@mergify mergify bot added the has conflicts label Jul 6, 2021
@carmocca carmocca requested review from tchaton and awaelchli July 6, 2021 10:59
@mergify mergify bot removed the has conflicts label Jul 6, 2021
@mergify mergify bot added the has conflicts label Jul 7, 2021
@carmocca carmocca enabled auto-merge (squash) July 7, 2021 12:24
@carmocca carmocca added the ready PRs ready to be merged label Jul 7, 2021
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready PRs ready to be merged refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants