-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove magic monitor support for ModelCheckpoint
#8293
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carmocca
requested review from
awaelchli,
Borda,
justusschock,
kaushikb11,
SeanNaren,
tchaton and
williamFalcon
as code owners
July 5, 2021 15:00
Codecov Report
@@ Coverage Diff @@
## master #8293 +/- ##
=======================================
+ Coverage 88% 92% +4%
=======================================
Files 213 213
Lines 13808 13797 -11
=======================================
+ Hits 12151 12730 +579
+ Misses 1657 1067 -590 |
awaelchli
reviewed
Jul 5, 2021
awaelchli
reviewed
Jul 5, 2021
tchaton
reviewed
Jul 6, 2021
awaelchli
approved these changes
Jul 7, 2021
tchaton
approved these changes
Jul 7, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
ethanwharris
approved these changes
Jul 7, 2021
This was referenced Feb 6, 2023
Training output is inconsistent with the document and the evaluation code
seisbench/pick-benchmark#5
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Remove deprecated support for relying on the magic monitor
val_loss
.save_top_k
does not need to beOptional
anymore.Before submitting
PR review