Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connect progress tracking dataclasses to loops #8244

Merged
merged 23 commits into from
Jul 5, 2021

Conversation

carmocca
Copy link
Contributor

@carmocca carmocca commented Jul 1, 2021

What does this PR do?

See title.

Part of #8131
Includes #8265

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@carmocca carmocca added feature Is an improvement or enhancement design Includes a design discussion labels Jul 1, 2021
@carmocca carmocca added this to the v1.4 milestone Jul 1, 2021
@carmocca carmocca self-assigned this Jul 1, 2021
@codecov
Copy link

codecov bot commented Jul 1, 2021

Codecov Report

Merging #8244 (7ceed96) into master (83039ba) will increase coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #8244   +/-   ##
======================================
  Coverage      92%     92%           
======================================
  Files         212     212           
  Lines       13727   13762   +35     
======================================
+ Hits        12683   12718   +35     
  Misses       1044    1044           

@carmocca carmocca changed the title Connect progress dataclasses Connect progress tracking dataclasses to loops Jul 1, 2021
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@carmocca carmocca marked this pull request as draft July 1, 2021 18:57
@carmocca carmocca marked this pull request as ready for review July 2, 2021 13:44
@carmocca carmocca added the ready PRs ready to be merged label Jul 3, 2021
@carmocca carmocca merged commit 3379477 into master Jul 5, 2021
@carmocca carmocca deleted the feat/connect-progress-dataclasses branch July 5, 2021 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Includes a design discussion feature Is an improvement or enhancement ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants