-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CLI] Drop ArgumentParser
when pickling and save before spawning
#8017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #8017 +/- ##
=======================================
- Coverage 93% 88% -5%
=======================================
Files 213 213
Lines 13808 13817 +9
=======================================
- Hits 12809 12144 -665
- Misses 999 1673 +674 |
11 tasks
ArgumentParser
when pickling and save before spawningArgumentParser
when pickling and save before spawning
Borda
approved these changes
Jul 2, 2021
11 tasks
carmocca
commented
Jul 7, 2021
awaelchli
approved these changes
Jul 7, 2021
kaushikb11
approved these changes
Jul 7, 2021
60ae800
to
ef40533
Compare
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
argparse (removed)
Related to argument parsing (argparse, Hydra, ...)
bug
Something isn't working
distributed
Generic distributed-related topic
ready
PRs ready to be merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
LightningCLI
config onsetup
and only on the main process. Fixes SaveConfigCallback: Race condition with ddp. #8003. This will also be necessary for Call any trainer function from theLightningCLI
#7508LightningCLI
ArgumentParser
when pickling. Fixes CLI:PicklingError: logger cannot be pickled
#8010broadcast
if distributed not initialized for the spawn plugins. This is necessary becausetrainer.log_dir
callsbroadcast
and we need to access it in thesetup
hook, where distributed has not been initialized for spawnBefore submitting
PR review