Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLI] Drop ArgumentParser when pickling and save before spawning #8017

Merged
merged 29 commits into from
Jul 7, 2021

Conversation

carmocca
Copy link
Contributor

@carmocca carmocca commented Jun 17, 2021

What does this PR do?

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@carmocca carmocca added bug Something isn't working distributed Generic distributed-related topic argparse (removed) Related to argument parsing (argparse, Hydra, ...) labels Jun 17, 2021
@carmocca carmocca added this to the v1.3.x milestone Jun 17, 2021
@carmocca carmocca self-assigned this Jun 17, 2021
@codecov
Copy link

codecov bot commented Jun 17, 2021

Codecov Report

Merging #8017 (d2acbfa) into master (01f594b) will decrease coverage by 5%.
The diff coverage is 69%.

@@           Coverage Diff           @@
##           master   #8017    +/-   ##
=======================================
- Coverage      93%     88%    -5%     
=======================================
  Files         213     213            
  Lines       13808   13817     +9     
=======================================
- Hits        12809   12144   -665     
- Misses        999    1673   +674     

@carmocca carmocca changed the title [WIP][CLI] Drop ArgumentParser when pickling and save before spawning [CLI] Drop ArgumentParser when pickling and save before spawning Jun 30, 2021
@carmocca carmocca marked this pull request as ready for review June 30, 2021 15:26
tests/utilities/test_cli.py Outdated Show resolved Hide resolved
@Borda Borda added this to the v1.4 milestone Jul 6, 2021
@edenlightning edenlightning modified the milestones: v1.4, v1.3.x Jul 6, 2021
@carmocca carmocca marked this pull request as ready for review July 7, 2021 12:26
@kaushikb11 kaushikb11 enabled auto-merge (squash) July 7, 2021 12:40
@carmocca carmocca added the ready PRs ready to be merged label Jul 7, 2021
@carmocca carmocca disabled auto-merge July 7, 2021 12:45
@carmocca carmocca enabled auto-merge (squash) July 7, 2021 12:47
@carmocca carmocca disabled auto-merge July 7, 2021 12:47
@carmocca carmocca force-pushed the bugfix/cli-drop-parser-spawn branch from 60ae800 to ef40533 Compare July 7, 2021 13:06
@carmocca carmocca enabled auto-merge (squash) July 7, 2021 16:43
@carmocca carmocca merged commit 368ac1c into master Jul 7, 2021
@carmocca carmocca deleted the bugfix/cli-drop-parser-spawn branch July 7, 2021 17:56
@carmocca carmocca mentioned this pull request Jul 7, 2021
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
argparse (removed) Related to argument parsing (argparse, Hydra, ...) bug Something isn't working distributed Generic distributed-related topic ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CLI: PicklingError: logger cannot be pickled SaveConfigCallback: Race condition with ddp.
5 participants