Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug/feat] Support parameters_to_ignore in DDP #7239

Merged
merged 5 commits into from
Apr 27, 2021

Conversation

tchaton
Copy link
Contributor

@tchaton tchaton commented Apr 27, 2021

What does this PR do?

This PR resolves a bug with DDP where parameters_to_ignore wasn't properly set from module to DDP wrapper.

Fixes #<issue_number>

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@pep8speaks
Copy link

pep8speaks commented Apr 27, 2021

Hello @tchaton! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-04-27 17:22:38 UTC

@codecov
Copy link

codecov bot commented Apr 27, 2021

Codecov Report

Merging #7239 (c4478bb) into master (f920ba2) will decrease coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #7239   +/-   ##
======================================
- Coverage      91%     91%   -0%     
======================================
  Files         198     198           
  Lines       12723   12748   +25     
======================================
+ Hits        11632   11634    +2     
- Misses       1091    1114   +23     

@tchaton tchaton added the bug Something isn't working label Apr 27, 2021
Copy link
Member

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😃

Copy link
Contributor

@ananthsub ananthsub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch!

Copy link
Contributor

@kaushikb11 kaushikb11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tchaton tchaton enabled auto-merge (squash) April 27, 2021 17:28
@tchaton tchaton merged commit 5a113a2 into master Apr 27, 2021
@tchaton tchaton deleted the _ddp_params_and_buffers_to_ignore branch April 27, 2021 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants