-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add on_predict_{batch,epoch}_{start,end}
and Callback.on_predict_{start,end}
#7141
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7141 +/- ##
=======================================
- Coverage 92% 86% -6%
=======================================
Files 197 197
Lines 12662 12796 +134
=======================================
- Hits 11674 11059 -615
- Misses 988 1737 +749 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
Need to add the calls on trainer callbacks too for the new ones.
on_predict_{batch,epoch}_{start,end}
and Callback.on_predict_{start,end}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ! Thanks.
What does this PR do?
Split out from #7042 and #7127
Notes:
self.log
is not allowed in the predict hookscc: @justusschock @tchaton
Before submitting
PR review