-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better approach to register plugins #7063
Better approach to register plugins #7063
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Eventually would we enable plugins outside this repo to add to this registry?
ddp_with_find_unused_parameters_false
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll approve but as ananth said, let's save the other config for a separate PR!
I have a few concerns of the name we gave ddp with find_unused_params=false since its quite long and I'd like the alias to be as small as possible :)
Eventually would we enable plugins outside this repo to add to this registry?
How would you envision this? I think other repos can add to the registry as normal, however these would be localized to the users' repository
ddp_with_find_unused_parameters_false
I have a few concerns of the name we gave ddp with find_unused_params=false since its quite long and I'd like the alias to be as small as possible :) Haha, @SeanNaren. I wasn't the biggest fan of the name either lol. Suggestions are welcome :)) |
Codecov Report
@@ Coverage Diff @@
## master #7063 +/- ##
========================================
Coverage ? 87%
========================================
Files ? 196
Lines ? 12616
Branches ? 0
========================================
Hits ? 10968
Misses ? 1648
Partials ? 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
What does this PR do?
Better approach to register plugins
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃