Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecation warning to ModelCheckpoint when logging val_loss with no monitor #6012

Merged
merged 5 commits into from
Feb 17, 2021

Conversation

carmocca
Copy link
Contributor

@carmocca carmocca commented Feb 16, 2021

What does this PR do?

Adds missing deprecation warning.

Context: #6004 (comment)

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR

@Borda Borda added the ready PRs ready to be merged label Feb 16, 2021
@codecov
Copy link

codecov bot commented Feb 16, 2021

Codecov Report

Merging #6012 (7708635) into master (f655f97) will increase coverage by 2%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #6012    +/-   ##
=======================================
+ Coverage      91%     93%    +2%     
=======================================
  Files         160     160            
  Lines       11313   11314     +1     
=======================================
+ Hits        10272   10496   +224     
+ Misses       1041     818   -223     

Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@Borda Borda force-pushed the deprecate-mc-compat branch from 83a0faf to 7ed2247 Compare February 16, 2021 22:59
@mergify mergify bot removed the has conflicts label Feb 16, 2021
@Borda Borda enabled auto-merge (squash) February 16, 2021 23:11
@Borda Borda force-pushed the deprecate-mc-compat branch from 44b1cfa to c8c248f Compare February 17, 2021 07:24
@Borda Borda merged commit 7aae589 into master Feb 17, 2021
@Borda Borda deleted the deprecate-mc-compat branch February 17, 2021 10:46
@Borda Borda removed this from the 1.2.x milestone Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready PRs ready to be merged refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants