Implement log_graph for CometLogger. #5295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neighthan
requested review from
awaelchli,
Borda,
justusschock,
SeanNaren,
tchaton and
williamFalcon
as code owners
Closed
awaelchli
approved these changes
Dec 30, 2020
Borda
approved these changes
Dec 31, 2020
Codecov Report
@@ Coverage Diff @@
## release/1.2-dev #5295 +/- ##
===============================================
Coverage 93% 93%
===============================================
Files 152 152
Lines 10732 10736 +4
===============================================
+ Hits 9944 9948 +4
Misses 788 788 |
Borda
requested review from
carmocca,
lezwon,
s-rog,
SkafteNicki and
yukw777
SkafteNicki
reviewed
Dec 31, 2020
s-rog
approved these changes
Jan 6, 2021
justusschock
approved these changes
Jan 7, 2021
tchaton
approved these changes
Jan 11, 2021
SkafteNicki
approved these changes
Jan 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the
log_graphmethod for theCometLogger(previously this was just inherited from the logger base class and did nothing) by calling Comet'sset_model_graph, if a CometML experiment exists (otherwise, nothing is done, as before).