-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate prefix argument in ModelCheckpoint #4765
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4765 +/- ##
======================================
Coverage 93% 93%
======================================
Files 117 117
Lines 8974 8977 +3
======================================
+ Hits 8347 8350 +3
Misses 627 627 |
ت |
tchaton
approved these changes
Nov 19, 2020
SkafteNicki
approved these changes
Nov 20, 2020
Borda
approved these changes
Nov 20, 2020
williamFalcon
approved these changes
Nov 21, 2020
rohitgr7
added a commit
that referenced
this pull request
Nov 21, 2020
* Deprecate prefix in ModelCheckpoint * chlog Co-authored-by: chaton <[email protected]> Co-authored-by: Jirka Borovec <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Deprecated prefix argument in ModelCheckpoint. It's no longer needed since we have
filename
now inModelCheckpoint
.#4557 (comment)
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In in short, see following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃