Bugfix/4449 dict attribute error #4480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tchaton
requested review from
ananyahjha93,
awaelchli,
Borda,
justusschock,
nateraw,
SeanNaren,
teddykoker and
williamFalcon
as code owners
|
Hello @tchaton! Thanks for updating this PR.
Comment last updated at 2020-11-04 18:45:38 UTC |
Codecov Report
@@ Coverage Diff @@
## master #4480 +/- ##
======================================
Coverage 93% 93%
======================================
Files 116 116
Lines 8718 8738 +20
======================================
+ Hits 8086 8108 +22
+ Misses 632 630 -2 |
…PyTorchLightning/pytorch-lightning into bugfix/4449_dict_attributeError
justusschock
approved these changes
Nov 3, 2020
SeanNaren
approved these changes
Nov 4, 2020
SkafteNicki
approved these changes
Nov 4, 2020
SeanNaren
suggested changes
Nov 4, 2020
pytorch_lightning/trainer/connectors/logger_connector/logger_connector.py
Outdated
Show resolved
Hide resolved
pytorch_lightning/trainer/connectors/logger_connector/logger_connector.py
Outdated
Show resolved
Hide resolved
SeanNaren
reviewed
Nov 4, 2020
pytorch_lightning/trainer/connectors/logger_connector/logger_connector.py
Outdated
Show resolved
Hide resolved
…onnector.py Co-authored-by: Sean Naren <[email protected]>
…onnector.py Co-authored-by: Sean Naren <[email protected]>
SeanNaren
approved these changes
Nov 4, 2020
7 tasks
rohitgr7
pushed a commit
that referenced
this pull request
Nov 21, 2020
* resolve a bug * resolve a bug * remove todo * resolve more bugs * update tests * Update pytorch_lightning/trainer/connectors/logger_connector/logger_connector.py Co-authored-by: Sean Naren <[email protected]> * Update pytorch_lightning/trainer/connectors/logger_connector/logger_connector.py Co-authored-by: Sean Naren <[email protected]> * resolve pyright Co-authored-by: Teddy Koker <[email protected]> Co-authored-by: Sean Naren <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR resolve 2 bugs related to logging, but one is still there. Reduction is not properly done on legacy results.
Fixes #4449
Fixes #3994
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃