-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix sigterm signal handling #10189
Merged
Merged
Fix sigterm signal handling #10189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awaelchli
requested review from
Borda,
carmocca,
justusschock,
kaushikb11,
rohitgr7,
SeanNaren,
tchaton and
williamFalcon
as code owners
October 27, 2021 14:57
awaelchli
changed the title
Fix info message for sigterm signal handler
Fix sigterm signal handling
Oct 27, 2021
SeanNaren
approved these changes
Oct 27, 2021
tchaton
approved these changes
Oct 27, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
Wow ! Awesome catch ! |
carmocca
reviewed
Oct 27, 2021
carmocca
approved these changes
Oct 28, 2021
Codecov Report
@@ Coverage Diff @@
## master #10189 +/- ##
========================================
+ Coverage 89% 92% +4%
========================================
Files 180 180
Lines 16193 16193
========================================
+ Hits 14339 14954 +615
+ Misses 1854 1239 -615 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #10154 and #9566
Before #9566, the special signal handler was only added for SLURM. Now, sigterm will be ignored by Lightning. only sigint can currently terminate a training process.
To reproduce, run
bug_report_model.py
and send sigterm (kill -15 process-name).Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
I made sure I had fun coding 🙃
Part of #1 (it's a lie, this is just here to avoid noisy GitHub bot)