Add lightning argument parser #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #246 +/- ##
==========================================
+ Coverage 88.31% 88.49% +0.17%
==========================================
Files 70 71 +1
Lines 3407 3485 +78
==========================================
+ Hits 3009 3084 +75
- Misses 398 401 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
Hello @nateraw! Thanks for updating this PR.
Comment last updated at 2020-09-23 01:10:58 UTC |
|
windows build is broken for unrelated reason it seems. we'll fix that in separate PR |
teddykoker
suggested changes
Sep 23, 2020
ananyahjha93
approved these changes
Sep 23, 2020
Borda
reviewed
Sep 23, 2020
| else: | ||
| root_cls = cls | ||
|
|
||
| blacklisted_args = ["self", "args", "kwargs"] |
There was a problem hiding this comment.
this shall be taken from the Function/method footprint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
What does this PR do?
Copy code over from #3537 to proof out the idea here before implementing directly in lightning.
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃