Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Fix tabular with no categorical fields #1144

Merged
merged 4 commits into from
Jan 31, 2022

Conversation

ethanwharris
Copy link
Collaborator

What does this PR do?

Fixes #1143

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@ethanwharris ethanwharris added the bug / fix Something isn't working label Jan 31, 2022
@codecov
Copy link

codecov bot commented Jan 31, 2022

Codecov Report

Merging #1144 (0354b20) into master (700a9c8) will increase coverage by 6.23%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1144      +/-   ##
==========================================
+ Coverage   82.94%   89.18%   +6.23%     
==========================================
  Files         285      285              
  Lines       13008    13008              
==========================================
+ Hits        10790    11601     +811     
+ Misses       2218     1407     -811     
Flag Coverage Δ
unittests 89.18% <100.00%> (+6.23%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/tabular/input.py 92.59% <100.00%> (ø)
flash/image/classification/data.py 97.63% <0.00%> (+1.57%) ⬆️
flash/core/data/transforms.py 96.49% <0.00%> (+1.75%) ⬆️
...ash/image/classification/integrations/baal/data.py 38.00% <0.00%> (+2.00%) ⬆️
flash/image/classification/input_transform.py 83.33% <0.00%> (+3.33%) ⬆️
flash/image/segmentation/data.py 100.00% <0.00%> (+3.70%) ⬆️
flash/image/classification/model.py 78.84% <0.00%> (+3.84%) ⬆️
.../image/classification/integrations/baal/dropout.py 42.85% <0.00%> (+4.76%) ⬆️
flash/image/classification/input.py 100.00% <0.00%> (+8.53%) ⬆️
flash/core/integrations/fiftyone/utils.py 64.70% <0.00%> (+13.72%) ⬆️
... and 35 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 700a9c8...0354b20. Read the comment docs.

@ethanwharris ethanwharris merged commit 87e683f into master Jan 31, 2022
@ethanwharris ethanwharris deleted the bugfix/tabular_no_categorical branch January 31, 2022 13:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug / fix Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot run on iris dataset
1 participant