Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Fix tabular with embedding_sizes=None #1067

Merged
merged 4 commits into from
Dec 14, 2021

Conversation

ethanwharris
Copy link
Collaborator

What does this PR do?

Fixes #1065

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@ethanwharris ethanwharris added the bug / fix Something isn't working label Dec 13, 2021
@codecov
Copy link

codecov bot commented Dec 13, 2021

Codecov Report

Merging #1067 (1b30f6d) into master (dd72360) will decrease coverage by 0.01%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1067      +/-   ##
==========================================
- Coverage   87.58%   87.57%   -0.02%     
==========================================
  Files         280      280              
  Lines       12743    12747       +4     
==========================================
+ Hits        11161    11163       +2     
- Misses       1582     1584       +2     
Flag Coverage Δ
unittests 87.57% <50.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/tabular/regression/model.py 54.34% <0.00%> (-2.48%) ⬇️
flash/tabular/classification/model.py 93.87% <100.00%> (+0.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd72360...1b30f6d. Read the comment docs.

@ethanwharris ethanwharris merged commit 70fcff6 into master Dec 14, 2021
@ethanwharris ethanwharris deleted the bugfix/tabular_embedding_sizes branch December 14, 2021 18:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug / fix Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TabularClassifier fails with embedding_sizes=None (the default)
3 participants