-
-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
auditwheel: generate single wheel for multiple eligible manylinux tags #523
Comments
What's the advantage of tagging multiple manylinux versions instead of just tagging the oldest one possible? |
I guess if we just tagging the oldest one there is no advantage. But if |
TBH I wrote maturin because I disagree with the behaviour of the official tools. They are often counterintuitive and lead to projects badly broken in subtle ways, which regularly causes problems in across different projects. I wanted maturin to be something that might support less things, but does them correctly. For |
I understand your concern. It's just not clear to me what kind of problem will this feature cause in practice, can you give some examples? |
I don't have any concrete examples, but from my experience software trying to be smarter than what the user explicitly requested always leads to problems eventually. With default options maturin is already tagging the lowest possible version and we also have the warning saying when a lower version would be possible, so imho this would only be a small gain. Sorry for rejecting this, I know this seems like an easy win but I think we're better off with just tagging the requested version. |
This will make it possible to support
manylinux1
wheel with--manylinux 2010
and later even if Rust doesn't run on CentOS 5.The text was updated successfully, but these errors were encountered: