Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Versioning: setuptools-scm compatibility #1283

Closed
miili opened this issue Nov 21, 2022 · 2 comments
Closed

Versioning: setuptools-scm compatibility #1283

miili opened this issue Nov 21, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@miili
Copy link

miili commented Nov 21, 2022

Hi all,

using https://github.com/pypa/setuptools_scm for version inference from git tags streamlines and automates the publishing workflow.
Unfortunately it is incompatible with maturin and the fixed version in Cargo.toml. How can maturin leverage this automation process?

I saw closed #199, stating:

PEP 621 also commited to having a static project.version field in the metadata just like cargo's package.version, so this a won't fix from maturin's side. If you need to do this just use sed to replace the version in a previous step of the CI pipeline

But this is not right, PEP 621 encourages project.dynamic fields.

Best,

M

@miili miili added the enhancement New feature or request label Nov 21, 2022
@messense
Copy link
Member

Duplicate of #1267, please continue the discussion there.

@messense messense closed this as not planned Won't fix, can't repro, duplicate, stale Nov 21, 2022
@rmorshea
Copy link

Are there any plans to support similar functionality within Maturin itself?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants