Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't set MACOSX_DEPLOYMENT_TARGET for macos wheels #112

Closed
b4stien opened this issue Dec 8, 2022 · 2 comments · Fixed by #113
Closed

Can't set MACOSX_DEPLOYMENT_TARGET for macos wheels #112

b4stien opened this issue Dec 8, 2022 · 2 comments · Fixed by #113
Labels
bug Something isn't working

Comments

@b4stien
Copy link

b4stien commented Dec 8, 2022

Trying to build wheels for both our Linux servers and our local macOS M1 machines I struggled with the latter. maturin-action currently hard sets MACOSX_DEPLOYMENT_TARGET to 10.9 (here) which generates a ...macosx_10_9_arm64.whl wheel not installable on macOS M1 13.0.1 (no idea if it doesn't work "at all" or specifically with my project or macOS 13.0.1).

Setting MACOSX_DEPLOYMENT_TARGET to 11.0 or simply letting rustc/cargo use their default values both seem to work, generating a functional/installable ...macosx_11_0_arm64.whl wheel (setting to 11.0 and no value).

What would be the best course forward? Would you accept a PR removing the default value?

@messense
Copy link
Member

messense commented Dec 8, 2022

Would you accept a PR removing the default value?

Sure, MACOSX_DEPLOYMENT_TARGET is now handled in maturin so it's not needed any more.

@messense messense added the bug Something isn't working label Dec 8, 2022
@b4stien
Copy link
Author

b4stien commented Dec 8, 2022

Thanks! 💪🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants