Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

E402: Add "with" statement to allowed keywords #834

Merged
merged 3 commits into from
Sep 25, 2019
Merged

E402: Add "with" statement to allowed keywords #834

merged 3 commits into from
Sep 25, 2019

Conversation

EricCousineau-TRI
Copy link
Contributor

Resolves #833

@EricCousineau-TRI EricCousineau-TRI mentioned this pull request Jan 30, 2019
Merged
@asottile
Copy link
Member

Should if be added as well?

@EricCousineau-TRI
Copy link
Contributor Author

SGTM. Will file as a separate commit, and split it into a separate PR if it causes issues.

@EricCousineau-TRI EricCousineau-TRI mentioned this pull request Jan 30, 2019
Closed
@EricCousineau-TRI
Copy link
Contributor Author

Done.

asottile
asottile approved these changes Jan 30, 2019
View reviewed changes
Copy link
Member

@asottile asottile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, I assumed you would do another pr - - here is perfect

@EricCousineau-TRI
Copy link
Contributor Author

Ah, sorry about that! And thanks!

asottile
asottile requested changes Jan 30, 2019
View reviewed changes
testsuite/E40.py Show resolved Hide resolved
asottile
asottile approved these changes Jan 30, 2019
View reviewed changes
Copy link
Member

@asottile asottile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@EricCousineau-TRI EricCousineau-TRI mentioned this pull request Jan 30, 2019
Merged
GPHemsley
GPHemsley reviewed Sep 21, 2019
View reviewed changes
pycodestyle.py Outdated Show resolved Hide resolved
@sigmavirus24 sigmavirus24 merged commit b93125a into PyCQA:master Sep 25, 2019
This was referenced Mar 15, 2021
Open
Closed
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GPHemsley GPHemsley GPHemsley left review comments

@asottile asottile asottile approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

E402: Add "with" to allowed_try_keywords
4 participants
@EricCousineau-TRI @asottile @GPHemsley @sigmavirus24