Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-add __main__.py to enable executing as a module #497

Merged
merged 3 commits into from
Mar 9, 2022
Merged

Re-add __main__.py to enable executing as a module #497

merged 3 commits into from
Mar 9, 2022

Conversation

michaeltinsley
Copy link

@michaeltinsley michaeltinsley commented Mar 9, 2022

Description

Re-adds __main__.py to enable executing as a module.
This was added in 0.12.6, and removed in 1.7.3.

Related Issue

Closes #496

Motivation and Context

With this, prospector paths don't need to be added.
In my experience, it also make integration with CI easier.

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • My change requires a change to the dependencies
  • I have updated the dependencies accordingly
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@michaeltinsley michaeltinsley marked this pull request as ready for review March 9, 2022 10:22
@michaeltinsley michaeltinsley marked this pull request as draft March 9, 2022 10:32
@michaeltinsley michaeltinsley marked this pull request as ready for review March 9, 2022 10:36
@carlio carlio merged commit c70b6cd into prospector-dev:develop Mar 9, 2022
@carlio
Copy link
Member

carlio commented Mar 9, 2022

Thanks! 👍

@michaeltinsley michaeltinsley deleted the develop branch March 9, 2022 10:51
@michaeltinsley
Copy link
Author

Thanks for the speedy turnaround, made my life a lot easier 👍

@carlio
Copy link
Member

carlio commented Mar 9, 2022

No worries, I'll make a small bugfix release tomorrow (it is a bug to me - something was working and now it's not!) - and thanks for the PR

carlio added a commit that referenced this pull request Mar 9, 2022
Re-add `__main__.py` to enable executing as a module
@carlio
Copy link
Member

carlio commented Mar 9, 2022

1.7.7 on PyPI now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants