Support more kinds of mypy messages

[rik]

Extracts a format_message to help unit testing

fix #339

[rik]

The mypy dependency is the reason the tests are failing. The tests don't use mypy at all but being in the same file, the import fails.

Some options:

• Move import mypy into MypyTool.__init__
• Move format_message into another file.
• Install mypy in test environments (and figure how to do it)

@chocoelho Do you have any preference on how to move forward here?

[chocoelho]

Can you point the PR to develop? We might still have chance to ship it in 1.1.7 and before that have a 1.1.7.dev1.

[rik]

That's done. Any opinion on how to pass tests?

[chocoelho]

@rik can you try updating .travis.yml install option to add mypy? Prob worth moving line 17 into 13 in this file and install only once.

[coveralls]

Coverage decreased (-0.7%) to 77.266% when pulling 387b025 on rik:339-mypy-messages into 6d97770 on PyCQA:develop.

[coveralls]

Coverage decreased (-0.7%) to 77.266% when pulling 387b025 on rik:339-mypy-messages into 6d97770 on PyCQA:develop.

[coveralls]

Coverage increased (+0.3%) to 78.267% when pulling f1eeb92 on rik:339-mypy-messages into 6d97770 on PyCQA:develop.

[rik]

The 2.7 failure seems to be https://sourceforge.net/p/docutils/bugs/365/.

[chocoelho]

@carlio as Python 2 support is being handled in https://github.com/landscapeio/prospector2 and discussed in here #265, do you think it makes sense dropping it from TravisCI?

[rik]

So docutils has been fixed but the 2.7 build is still failing because mypy is not installed on 2.7 builds.

[carlio]

@chocoelho ahem "handled" I had largely ignored it :-) but yes the idea was that prospector is py3 only as of that point and prospector2 will deal with anyone stuck using 2.

[chocoelho]

@rik there are two approaches we can take here:

1. check for the python version before the tests which could lead to a bunch of repeated code just to check this
2. implement a decorator that would behave as a skipIf, just like pytest does (IIRC, unittest does have a skip decorator of some sort but I'm not sure whether it would work for test classes or if nosetest would respect it)

[chocoelho]

LGTM 👍
Thanks for the contribution, will add you to the contributors list in develop branch.

[rik]

Thanks for maintaining this very useful tool!

[chocoelho]

You're welcome! We just published 1.1.7.dev1 with this fix, hope we release 1.1.7 soon.