You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mypy doesn't output a code to identify the errors, it basically works with options you pass on the command line and the interface available to integrate with other tools accepts these arguments, so that's why it's not following the pattern of using disable messages but rather entries like disallow, no-check and so on.
This PR is going to take a little while longer to be merged. After syncing with the develop branch, I'm going to write a few more tests just to make sure it's properly integrated. But we're back on business :)
@twidi flake8 operates on single files, while mypy analyzes a complete codebase. The flake8-mypy plugin is therefore somewhat limited. Basically this note from the flake8-mypy page says it all:
Flake8 operates on unrelated files, it doesn’t perform full program analysis. In other words, it doesn’t follow imports. This is a curse and a blessing. We cannot find complex problems and the number of warnings we can safely show without risking false positives is lower. In return, we can provide useful warnings with great performance, usable for realtime editor integration.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves #198.
mypy
doesn't output a code to identify the errors, it basically works with options you pass on the command line and the interface available to integrate with other tools accepts these arguments, so that's why it's not following the pattern of usingdisable
messages but rather entries likedisallow
,no-check
and so on.These are some screenshots of it working:
Running only with mypy tool
VS Code output
.prospector.yaml configuration