Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruff rules B017, B028, and E203 #2371

Merged
merged 1 commit into from
Feb 20, 2025

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Feb 20, 2025

As requested at #2359 (comment)

Stop ignoring ruff rules

ruff rule E203 # is disabled by default in ruff (but not flake8) because it conflicts with black and ruff format.

Copy link

codecov bot commented Feb 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.16%. Comparing base (1157b58) to head (1708f3e).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2371   +/-   ##
=======================================
  Coverage   99.16%   99.16%           
=======================================
  Files          40       40           
  Lines        3101     3101           
  Branches      680      680           
=======================================
  Hits         3075     3075           
  Misses         15       15           
  Partials       11       11           

@cclauss cclauss force-pushed the ruff-rules-B017-B028-E203 branch 2 times, most recently from 4aa8867 to bff25d9 Compare February 20, 2025 09:02
Copy link
Member

@DanielNoord DanielNoord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cclauss

@cclauss cclauss force-pushed the ruff-rules-B017-B028-E203 branch from bff25d9 to 03d6d98 Compare February 20, 2025 13:18
@cclauss cclauss force-pushed the ruff-rules-B017-B028-E203 branch from 03d6d98 to 1708f3e Compare February 20, 2025 13:24
Copy link
Collaborator

@staticdev staticdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellebt @cclauss! Thanks

@staticdev staticdev added this pull request to the merge queue Feb 20, 2025
Merged via the queue into PyCQA:main with commit 3305894 Feb 20, 2025
21 checks passed
@cclauss cclauss deleted the ruff-rules-B017-B028-E203 branch February 20, 2025 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants