Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default to running with --in-place in pre-commit hook #78

Closed
graingert opened this issue Sep 20, 2020 · 2 comments · Fixed by #121
Closed

default to running with --in-place in pre-commit hook #78

graingert opened this issue Sep 20, 2020 · 2 comments · Fixed by #121

Comments

@graingert
Copy link
Member

No description provided.

@spookylukey
Copy link

At the very least the hook should pass -c argument so that you get notified of issues.

The current behaviour of the hook without arguments is that it always prints:

autoflake................................................................Passed

Which is not very helpful :-)

But I'd also prefer defaulting to --in-place - given the tool is about automatically making changes. If I just want notifications, then I can use flake8 as a commit hook.

@max-sixty
Copy link

Agree — would it be reasonable to have the suggested entry at #62 (comment) be the default?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants