-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: Make local_variables a dictionary instead of a list of strings #79
Conversation
03c0d03
to
a2ffd95
Compare
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Konrad Jałowiecki.
|
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Konrad Jałowiecki.
|
6af5af7
to
b06f09b
Compare
Description
Currently, we store local variables as a list of strings, each of them of the form "symbol = expression", e.g.:
However, each time such variables are processed, this lists of strings gets converted to a dictionary. Therefore, it is only natural to make
local_variables
a dictionary in the first place, so that the example above looks like:which is what this PR does.
While refactoring this, some functions became obsolete and were thus removed from the codebase entirely as a part of this PR.
Please verify that you have completed the following steps