fix: Fix nontrivial input port size support #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mstechly
approved these changes
Oct 24, 2024
tests/compilation/test_compile.py
Outdated
| @@ -141,3 +141,48 @@ def test_compile_errors(routine, expected_error, backend): | |||
| compile_routine( | |||
| routine, preprocessing_stages=[introduce_port_variables], backend=backend, skip_verification=True | |||
| ) | |||
|
|
|||
|
|
|||
| def test_compilation_introduces_constraints_stemming_from_relation_between_port_sizes(backend): | |||
There was a problem hiding this comment.
I think it's also worth adding a fun(N) to make sure parsing functions also works in this context?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #127 by introducing relevant logic for handling non-trivial input port sizes depending on other ports.
Please verify that you have completed the following steps