Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhancment/issue 134 drop commonjs bundle #189

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

enhancment/issue 134 drop commonjs bundle #189

wants to merge 4 commits into from

Conversation

thescientist13
Copy link
Member

@thescientist13 thescientist13 commented Feb 6, 2025 •
edited
Loading

Related Issue

resolves #134

Summary of Changes

  1. Remove Rollup config, deps and dist task
  2. NodeJS now supports require(ESM) I'm feeling good we can go back to using URL (and confirmed in Greenwood)
  3. Update README

TODO

  1. Should confirm if this is (still) safe to do - remove https://github.com/ProjectEvergreen/wcc/blob/0.12.1/src/wcc.js#L135 / WCC dropping query params when loading module URLs #158
  2. remove dist/ from files field in package.json

@thescientist13 thescientist13 added documentation Improvements or additions to documentation enhancement Improvement to existing functionality breaking labels Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briangrider briangrider Awaiting requested review from briangrider

Assignees
No one assigned
Labels
breaking documentation Improvements or additions to documentation enhancement Improvement to existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

drop support for CommonJS distribution
1 participant
@thescientist13