Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong typing for writer parameter of SaveImage #4560

Closed
function2-llx opened this issue Jun 22, 2022 · 0 comments · Fixed by #4561
Closed

Wrong typing for writer parameter of SaveImage #4560

function2-llx opened this issue Jun 22, 2022 · 0 comments · Fixed by #4561

Comments

@function2-llx
Copy link
Contributor

function2-llx commented Jun 22, 2022

Currently, the typing for writer parameter of SaveImage is Union[image_writer.ImageWriter, str, None]. But it is supposed to be some class, thus the image_writer.ImageWriter part in the Union should be Type[image_writer.ImageWriter] where Type is from typing module.

I can make a simple fix and submit a PR. Maybe we could check if there's any similar issue in other parts of the code base.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant