Treeview: Fixed icons on dark themes #2631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RunDevelopment
commented
Nov 12, 2020
| @@ -100,14 +100,16 @@ async function getLog(range) { | |||
| } | |||
|
|
|||
| const revisionRanges = { | |||
| nextRelease: git.raw(['describe', '--abbrev=0', '--tags']).then(res => `${res.trim()}..HEAD`) | |||
There was a problem hiding this comment.
I have no idea why but this crashed the build with a
fatal: No names found, cannot describe anything.
No other information given.
It worked before, so my guess is that either GH made a slight change to how PRs are setup on workflows or that webfont or one of its dependencies messes with git in some way. This problem doesn't occur locally.
No idea what the error is or why it happened but I fixed it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #2630.
I also minified the SVGs themselves. (Hard to see with the base64 thou).After this brilliant idea by @xjArea, I changed Treeview's styles to use an icon font. All formerly base64-encoded icons were extracted into a new
plugins/treeview/iconsfolder. The extracted SVGs are both optimized and formatted.The WOFF icon font is automatically generated using webfont. The build process will then automatically inline the font into the
prism-treeview.cssfile as a@font-facerule along with an explanation on how to use the font.This also decreases the file size of the CSS file, from 18KB down to 8KB.
Tested for Chrome 86, FF 81, and IE11.