-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add language BSL (1C:Enterprise) #2520
Conversation
First, please let me apologize. I assumed that you made a language definition for private use in which case the To make the tests pass, we have to get rid of the Getting rid of the ES2018 lookbehinds is easy: you just have to use workaround 2. Getting rid of the Instead, let's redefine the problem. Since we only really need to support Cyrillic script, we can cut down on the numbers of characters. Instead of |
…d2b\u1d78\u2de0-\u2dff\ua640-\ua69f\ufe2e\ufe2f] Delete flag /u
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
npm run test:languages
only runs the language tests (the test cases undertests/languages
). Unfortunately, there isn't an option to run all tests for a specific language yet.- We are planning to move to ES6 eventually, so the
u
flag will be supported natively then. This doesn't completely solve the issue but it certainly helps.
Supporting theu
flag right now means transpiling code which can create huge patterns (e.g. 4kB for a single\p{L}
). This is a problem because the relatively small size of our language definitions is one of Prism's strong points. - That's because of the ES2018 lookbehind. See comments.
- See comments.
I also suggested a few other improvements.
Co-authored-by: Michael Schmidt <[email protected]>
Co-authored-by: Michael Schmidt <[email protected]>
Co-authored-by: Michael Schmidt <[email protected]>
Co-authored-by: Michael Schmidt <[email protected]>
Co-authored-by: Michael Schmidt <[email protected]>
Thank you for your help. I will be happy if my changes for the new BSL language are added to the main repository. In Russia, this language is very popular and has a huge community. |
Thanks for the changes @Diversus23! Apart from my two comments, I think this is ready to be merged. Please resolve the merge conflicts. This should be as simple as merging our master branch run running |
There are still 4 files that changed:
You also have to revert |
Seems like you accidentally committed the |
You can make JSDoc generate the correct line ends by converting the line ends of Btw. I filed a bug report about the |
I only ran |
Sorry, that's a problem on our part. I will fix this soon. Until then. to make the CI pass, do the following:
Again, I'm really sorry that this is so difficult. This isn't something anybody should have to deal with. This will be fixed soon. |
Thank you for contributing @Diversus23! |
Thank you @RunDevelopment! |
The language BSL (1C:Enterprise) added.
There is one problem, since the constructions use /u (Cyrillic language constructions are used) the "npm test" command is down.