Added popular VScode theme Night Owl #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RunDevelopment
requested changes
Mar 17, 2021
There was a problem hiding this comment.
Thank you for the PR.
I have one comment and then there is licensing. You are not the owner of this theme. @sdras licensed the theme using MIT, so we have to adhere to that license. Please add a comment to the CSS file crediting @sdras along with these lines of the license.
|
@RunDevelopment , Thanks for the generous suggestion . Quickly fixing it. |
|
I'm really sorry for the delay @SimpleIndian! LGTM; |
RunDevelopment
approved these changes
May 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also the formatted readme file.
@RunDevelopment , please review these changes.