Update Coldark Themes - Minor color change #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With some ports, some errors in the terminal were not readable. By changing the red color, readability is improved. This update is not unique to Prism and should not change the visual. All Coldark ports are updated to use the correct colors. See ArmandPhilippot/coldark-vscode#1
Yeah, these tokens aren't used in the screenshots. |
RunDevelopment
approved these changes
Nov 22, 2020
This was referenced Mar 15, 2021
bors bot
referenced
this pull request
in aDotInTheVoid/xmark-js
Mar 15, 2021
98: fix(deps): bump prism-themes from 1.5.0 to 1.6.0 r=aDotInTheVoid a=dependabot[bot] Bumps [prism-themes](https://github.com/prismjs/prism-themes) from 1.5.0 to 1.6.0. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/PrismJS/prism-themes/commit/f84f75916c8c192bbf102cdb622ffda319f9061a"><code>f84f759</code></a> 1.6.0</li> <li><a href="https://github.com/PrismJS/prism-themes/commit/367177199c23d5d0f8ab1421435a87d41a5f4c10"><code>3671771</code></a> Removed incorrect <code>main</code> field in <code>package.json</code> (<a href="https://github.com/prismjs/prism-themes/issues/114">#114</a>)</li> <li><a href="https://github.com/PrismJS/prism-themes/commit/07e8d2546601fd7e8aabbcb5f406d04abec8ad2c"><code>07e8d25</code></a> Adding Lucario theme (<a href="https://github.com/prismjs/prism-themes/issues/112">#112</a>)</li> <li><a href="https://github.com/PrismJS/prism-themes/commit/295bc134135c37d802b6d545dd95a6e8dde40600"><code>295bc13</code></a> Added Gruvbox Dark theme (<a href="https://github.com/prismjs/prism-themes/issues/110">#110</a>)</li> <li><a href="https://github.com/PrismJS/prism-themes/commit/c24ddffde2737293d9b2df7dc59939d527648863"><code>c24ddff</code></a> Updated Coldark Themes - Minor color change (<a href="https://github.com/prismjs/prism-themes/issues/109">#109</a>)</li> <li><a href="https://github.com/PrismJS/prism-themes/commit/e12fcfcd61bae382469b61ee61c9a8a23c30994c"><code>e12fcfc</code></a> Update Coldark Themes (<a href="https://github.com/prismjs/prism-themes/issues/107">#107</a>)</li> <li>See full diff in <a href="https://github.com/prismjs/prism-themes/compare/v1.5.0...v1.6.0">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With some ports, some errors in the terminal were not readable. By changing the red color, readability is improved. This update is not unique to Prism and should not change the visual (red is only used for invalid elements or deletions). All Coldark ports are updated to use the correct colors.
See ArmandPhilippot/coldark-vscode#1
This time, I think the Prism version is pretty stable. Unless there is a change in Prism tokens, this version should no longer evolve.
I have not regenerated screenshots since they do not use the color red for this theme. I ran
npm testand no error came out.