Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Balances Don't Update On Network Change #1

Closed
dOrgJelli opened this issue Nov 3, 2020 · 1 comment
Closed

Balances Don't Update On Network Change #1

dOrgJelli opened this issue Nov 3, 2020 · 1 comment
Labels
good first issue Good for newcomers wontfix This will not be worked on

Comments

@dOrgJelli
Copy link

If a user changes their network within Metamask, the balances on the balance page do not update. A hard refresh is required via navigation or browser refresh.
@emoon-dev emoon-dev added good first issue Good for newcomers wontfix This will not be worked on labels Nov 3, 2020
@emoon-dev
Copy link
Contributor

emoon-dev commented Nov 3, 2020 •
edited
Loading

This actually turns out to be more complicated than one might think. See the ethers commentary in this thread ethers-io/ethers.js#589 with extensive notes from @ricmoo and @danfinley. The basics for network change detection is in the dapp template and someone who wanted to provide robust support for other networks could do so. Resolving this as won't fix as it is beyond the scope of this boilerplate template.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers wontfix This will not be worked on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dOrgJelli @emoon-dev